Adding null to string dtype conversion (#263)

Adding null to string dtype conversion to close #262
pola-rs · Sep 4, 2024 · 1828912 · 1828912
1 parent 08d181f
commit 1828912
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/__tests__/io.test.ts b/__tests__/io.test.ts
@@ -169,6 +169,16 @@ describe("read:json", () => {
       json.slice(0, 30),
     );
   });
+  it("can read null json from buffer", () => {
+    const json = [
+      JSON.stringify({ bar: 1, foo: "a", nul: null }),
+      JSON.stringify({ bar: 2, foo: "b", nul: null }),
+      "",
+    ].join("\n");
+    const df = pl.readJSON(Buffer.from(json), { format: "lines" });
+    const actualCols = df.getColumns().map((x) => x.dtype);
+    expect(actualCols).toEqual([pl.Int64, pl.Utf8, pl.Null]);
+  });
 });
 
 describe("scan", () => {

diff --git a/src/conversion.rs b/src/conversion.rs
@@ -963,6 +963,7 @@ impl ToNapiValue for Wrap<DataType> {
                 obj.set("inner", inner_arr)?;
                 Object::to_napi_value(env, obj)
             }
+            DataType::Null => String::to_napi_value(env, "Null".to_owned()),
             DataType::Time => String::to_napi_value(env, "Time".to_owned()),
             DataType::Object(..) => String::to_napi_value(env, "Object".to_owned()),
             DataType::Categorical(..) => String::to_napi_value(env, "Categorical".to_owned()),