Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Fix test failing due to new adbc release #10763

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Aug 28, 2023

Apparently, the main. prefix for table names is no longer needed.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Aug 28, 2023
@stinodego stinodego merged commit 079e6b9 into main Aug 28, 2023
14 checks passed
@stinodego stinodego deleted the fix-adbc-test branch August 28, 2023 21:37
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Aug 29, 2023

Apparently, the main. prefix for table names is no longer needed.

I'll need to check this out; it's part of the test that this works - if it doesn't then something somewhere has probably gone wrong - disabling the test isn't correct here.

Update: I'll be taking a look once I get to my next lunch/coffee break ;)

@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Aug 29, 2023

Ok, this appears to be an ADBC gremlin in the latest release rather than an issue on our side; something has changed in the way tables are identified/validated, and it's (incorrectly) raising an exception on use of the implicit SQLite main schema.

I've raised an Issue (apache/arrow-adbc#1000) with a minimal test-case to demonstrate the problem; we'll have to wait for a fix before reinstating use of main as I don't think we can solve this externally.

@stinodego
Copy link
Member Author

disabling the test isn't correct here

Woops, I actually meant to tag you but it was late and I forgot...

this appears to be an ADBC gremlin

Ah - maybe it's better to revert this commit and skip the test with a reference to that issue?

It would also be good to break up this test as it's doing too many things at once...

@alexander-beedie
Copy link
Collaborator

It would also be good to break up this test as it's doing too many things at once...

Yup, that sounds like a good idea - I'll do that and we can isolate the issue a little better in the unit tests.

@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Aug 29, 2023

Ouch; while reconfiguring our tests I noticed that it's worse than not being able to reference main - the new 0.6.0 release also completely breaks for SQLite table names that require quoting (fortunately the PostgreSQL driver still works correctly in these cases). I've updated the bug report to provide test-cases/examples for both scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants