fix: support append/extend with null series (#11824)
#12686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any `Series` can now be `append`-ed or `extend`-ed with a series of null dtype.
tkarabela
requested review from
ritchie46,
stinodego,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
github-actions
bot
added
fix
|
Thank you @tkarabela |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a partial fix for issue #11824. It solves the case when one cannot
df1.vstack(df2)because eg.df1["x"].dtype == pl.Int64butdf2["x"].dtype == pl.Null.#11824 also mentions a more complex example, when we get conflict between eg.
List[Int64]andList[Null]. This is related to behaviour introduced by PR #12677 which produces theseList[Null]columns when parsing empty JSON arrays.