-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support with_projection and with_columns in ipc and parquet reader in eager mode #1751
Merged
ritchie46
merged 6 commits into
pola-rs:master
from
illumination-k:feature/read-with-column-names
Nov 13, 2021
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b01e38a
implementing with_columns and with_projection, rewriting finish in ip…
illumination-k acc0ff9
add test and docstring in ipc and parquet reader
illumination-k 916b9ac
fix: construct vec with capacity
illumination-k 6fb39b6
expose columns in the python API
illumination-k 863c201
fix: remove comments
illumination-k 0890a44
fix: sort -> sort_unstable
illumination-k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also remove duplicates after sorting:
https://github.com/jorgecarleitao/arrow2/blob/3caa20421f8a6950dec6e2ad1c54125ef3a896ab/src/io/ipc/read/reader.rs#L236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we can remove duplicates, but It seems that it would be more helpful to return an error if there is a duplicate.
It's not good to get an error in
select C, B
, but wouldn't it be better to get an error inselect B, B
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer returning an error indeed. The API expects unique columns.