Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix panic streaming parquet scan from cloud with slice #18202

Merged
merged 3 commits into from
Aug 19, 2024
Merged

fix: Fix panic streaming parquet scan from cloud with slice #18202

merged 3 commits into from
Aug 19, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #18181

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 15, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review August 15, 2024 10:56
@nameexhaustion
Copy link
Collaborator Author

failing test is delta lake

______________________________ test_write_delta _______________________________
[gw2] win32 -- Python 3.12.4 D:\a\polars\polars\py-polars\.venv\Scripts\python.exe
tests\unit\io\test_delta.py:177: in test_write_delta
    v1.write_delta(tmp_path)
polars\dataframe\frame.py:4109: in write_delta
    write_deltalake(

@nameexhaustion nameexhaustion marked this pull request as draft August 15, 2024 10:57
@nameexhaustion nameexhaustion marked this pull request as ready for review August 15, 2024 12:25
@ritchie46 ritchie46 merged commit 59e5e5a into pola-rs:main Aug 19, 2024
19 of 21 checks passed
@nameexhaustion nameexhaustion deleted the pq-cloud-slice branch August 29, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic occurring when using streaming and limit with Parquet
2 participants
@nameexhaustion @ritchie46