Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use or_else for raising #18206

Merged
merged 2 commits into from
Aug 15, 2024
Merged

chore: Use or_else for raising #18206

merged 2 commits into from
Aug 15, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Aug 15, 2024
@@ -1021,6 +1021,7 @@ def _arithmetic(self, other: Any, op_s: str, op_ffi: str) -> Self:
else:
other = maybe_cast(other, self.dtype)
f = get_ffi_func(op_ffi, self.dtype, self._s)
print(f)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this one got in by mistake? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oei.. yes.

@ritchie46 ritchie46 merged commit fe21f4a into main Aug 15, 2024
17 of 19 checks passed
@ritchie46 ritchie46 deleted the err branch August 15, 2024 08:04
@c-peters c-peters added the accepted Ready for implementation label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants