Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix failed AWS credential load from '~/.aws/credentials' due to formatting #18259

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Aug 19, 2024

As it turns out, this functionality was already there (ref #13062) - it's just that it failed to load if the credential lines didn't have space padding 😄. But now we will be able to load them regardless of spaces.

Fixes #18254

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.24%. Comparing base (1dc2533) to head (39f07ea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18259   +/-   ##
=======================================
  Coverage   80.23%   80.24%           
=======================================
  Files        1500     1500           
  Lines      198889   198892    +3     
  Branches     2837     2837           
=======================================
+ Hits       159573   159595   +22     
+ Misses      38789    38770   -19     
  Partials      527      527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review August 19, 2024 06:47
@ritchie46
Copy link
Member

As it turns out, this functionality was already there (ref #13062)

Always nice if my former self helped. ^^

@ritchie46 ritchie46 merged commit 6486cf1 into pola-rs:main Aug 19, 2024
23 checks passed
@nameexhaustion nameexhaustion deleted the aws-cred branch August 29, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 credentials aren't loaded from ~/.aws/config if equals aren't padded with spaces
2 participants