Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Change fn schema to fn collect_schema #18261

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

ritchie46
Copy link
Member

Rename schema to collect_schema to indicate we are doing work.

@ritchie46 ritchie46 changed the title refactor(rust): fn schema -> fn collect_schema refactor(rust): Change fn schema to fn collect_schema Aug 19, 2024
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars and removed title needs formatting labels Aug 19, 2024
@ritchie46 ritchie46 merged commit 02f95bf into main Aug 19, 2024
22 of 23 checks passed
@ritchie46 ritchie46 deleted the schema branch August 19, 2024 08:58
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.22%. Comparing base (5d874b1) to head (7ce2517).
Report is 48 commits behind head on main.

Files Patch % Lines
crates/polars-python/src/lazygroupby.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18261      +/-   ##
==========================================
- Coverage   80.25%   80.22%   -0.03%     
==========================================
  Files        1500     1500              
  Lines      198906   198906              
  Branches     2837     2837              
==========================================
- Hits       159641   159582      -59     
- Misses      38738    38797      +59     
  Partials      527      527              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants