docs: Clarify coalesce behaviour in join_asof
#18273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
coalesce behaviour in join_asofcoalesce behaviour in join_asof
github-actions
bot
added
documentation
MarcoGorelli
force-pushed
the
join-asof-coalesce
branch
from
6f147d7
to
5ee4bb2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18273 +/- ##
==========================================
- Coverage 80.21% 80.20% -0.02%
==========================================
Files 1500 1500
Lines 198897 198896 -1
Branches 2837 2837
==========================================
- Hits 159547 159516 -31
- Misses 38822 38852 +30
Partials 528 528 ☔ View full report in Codecov by Sentry. |
MarcoGorelli
requested review from
ritchie46,
c-peters,
alexander-beedie,
reswqa and
orlp
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18089
Join asof is like a left-join, so I think the argument (and description) can be simplified too, right? it's either true or false, nothing join-dependent