refactor(rust): Add DataFrame::new_with_broadcast and simplify column uniqueness checks #18285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
… uniqueness checks
orlp
force-pushed
the
new-with-broadcast
branch
from
3e9b98a
to
c402c20
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18285 +/- ##
=======================================
Coverage 80.21% 80.21%
=======================================
Files 1501 1501
Lines 198911 198916 +5
Branches 2837 2837
=======================================
+ Hits 159557 159566 +9
+ Misses 38826 38822 -4
Partials 528 528 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Aug 21, 2024
crates/polars-core/src/frame/mod.rs
Outdated
| } | ||
| // Converts a sequence of columns into a DataFrame, broadcasting length-1 | ||
| // columns to match the other columns. | ||
| pub fn new_with_broadcast(mut columns: Vec<Series>) -> PolarsResult<Self> { |
There was a problem hiding this comment.
Can we add a variant where we don't check for the unique names. In the IR we already have resolved this.
ritchie46
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.