Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Json feature flag missing imports #18305

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix: Json feature flag missing imports #18305

merged 2 commits into from
Aug 22, 2024

Conversation

sunadase
Copy link
Contributor

Fixes: #18258

Some codepaths included in json flag needed imports that are only supplied by possibly other (parquet/ipc + parquet) flags but not with json flag and polars_io::SerReader was missing altogether.

Not sure if this is the way you handle flags for this repo, you can let me know if within function imports are preferred? It could be better in case of use polars_io::SerReader's case, since requiring count_rows_ndjson function is behind a json flag already.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (84d6f80) to head (480bbf1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18305      +/-   ##
==========================================
- Coverage   80.23%   80.21%   -0.03%     
==========================================
  Files        1501     1501              
  Lines      198943   198915      -28     
  Branches     2837     2837              
==========================================
- Hits       159616   159553      -63     
- Misses      38799    38834      +35     
  Partials      528      528              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunadase sunadase changed the title fix: json feature flag missing imports fix: Json feature flag missing imports Aug 21, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Aug 21, 2024
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ritchie46 ritchie46 merged commit f7e63dc into pola-rs:main Aug 22, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to compile polars 0.42.0
2 participants