fix: Json feature flag missing imports #18305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18258
Some codepaths included in json flag needed imports that are only supplied by possibly other (parquet/ipc + parquet) flags but not with json flag and polars_io::SerReader was missing altogether.
Not sure if this is the way you handle flags for this repo, you can let me know if within function imports are preferred? It could be better in case of use polars_io::SerReader's case, since requiring count_rows_ndjson function is behind a json flag already.