-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rust): Lower arbitrary expressions in the new streaming engine #18315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
An internal refactor or improvement
rust
Related to Rust Polars
labels
Aug 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18315 +/- ##
==========================================
- Coverage 80.35% 80.24% -0.11%
==========================================
Files 1501 1502 +1
Lines 199236 199531 +295
Branches 2837 2837
==========================================
+ Hits 160087 160105 +18
- Misses 38623 38900 +277
Partials 526 526 ☔ View full report in Codecov by Sentry. |
Looking an awe at the complexity involved into a seemingly "simple" query. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most non-elementwise expressions still fall back to the in-memory-map, but at least the groundwork is laid for lowering more and more expressions to the streaming engine over time.
Known bug: common subexpression elimination does not work for the streaming engine in general.
An example: