Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Lazy decompress Parquet pages #18326

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

coastalwhite
Copy link
Collaborator

This only decompresses pages if they are actually going to be read from. This is only possible for unnested values and should save quite some time on slice pushdown and parallel=prefiltered.

This only decompresses pages if they are actually going to be read from. This
is only possible for unnested values and should save quite some time on slice
pushdown and `parallel=prefiltered`.
@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.35%. Comparing base (a601ccf) to head (7c23f61).
Report is 21 commits behind head on main.

Files Patch % Lines
...tes/polars-parquet/src/parquet/read/compression.rs 71.42% 4 Missing ⚠️
.../polars-parquet/src/arrow/read/deserialize/null.rs 71.42% 2 Missing ⚠️
...parquet/src/arrow/read/deserialize/nested_utils.rs 75.00% 1 Missing ⚠️
...rs-parquet/src/arrow/read/deserialize/utils/mod.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18326   +/-   ##
=======================================
  Coverage   80.35%   80.35%           
=======================================
  Files        1501     1501           
  Lines      199236   199241    +5     
  Branches     2837     2837           
=======================================
+ Hits       160087   160108   +21     
+ Misses      38623    38607   -16     
  Partials      526      526           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 72a7f4c into pola-rs:main Aug 23, 2024
22 checks passed
ritchie46 pushed a commit that referenced this pull request Aug 23, 2024
@c-peters c-peters added the accepted Ready for implementation label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants