Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unused Parquet indexes #18329

Merged

Conversation

coastalwhite
Copy link
Collaborator

This is not used anywhere in the code except the tests.

This is not used anywhere in the code except the tests.
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.54%. Comparing base (a601ccf) to head (9b97436).
Report is 21 commits behind head on main.

Files Patch % Lines
crates/polars-parquet/src/parquet/write/page.rs 50.00% 4 Missing ⚠️
crates/polars-parquet/src/parquet/page/mod.rs 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18329      +/-   ##
==========================================
+ Coverage   80.35%   80.54%   +0.19%     
==========================================
  Files        1501     1491      -10     
  Lines      199236   198349     -887     
  Branches     2837     2837              
==========================================
- Hits       160087   159769     -318     
+ Misses      38623    38054     -569     
  Partials      526      526              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit c37bad2 into pola-rs:main Aug 23, 2024
22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants