Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Only instantiate used portion of graph #18337

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Aug 23, 2024

During our lowering to a PhysicalPlan we end up producing some physical plan nodes that end up going unused (e.g. because a node ends up being input independent). We ended up spawning execution graph nodes for this which caused failed asserts, etc.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (c37bad2) to head (3f1dc7f).
Report is 14 commits behind head on main.

Files Patch % Lines
crates/polars-stream/src/physical_plan/to_graph.rs 0.00% 2 Missing ⚠️
crates/polars-stream/src/skeleton.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18337      +/-   ##
==========================================
- Coverage   80.42%   80.42%   -0.01%     
==========================================
  Files        1492     1492              
  Lines      198644   198676      +32     
  Branches     2837     2841       +4     
==========================================
+ Hits       159769   159792      +23     
- Misses      38349    38359      +10     
+ Partials      526      525       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 5cfc1f0 into pola-rs:main Aug 24, 2024
24 checks passed
@c-peters c-peters added the accepted Ready for implementation label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants