Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump Rust toolchain to nightly-2024-08-26 #18370

Merged
merged 4 commits into from
Aug 26, 2024
Merged

build: Bump Rust toolchain to nightly-2024-08-26 #18370

merged 4 commits into from
Aug 26, 2024

Conversation

stinodego
Copy link
Member

The new toolchain includes two new lints:

  • A lint for using if let instead of a match statement in certain cases.
  • A lint for splitting a docstring summary from the rest of the docstring (similar to what we have in Python).

@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars labels Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (aa283e6) to head (5fb0890).
Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18370      +/-   ##
==========================================
- Coverage   79.83%   79.81%   -0.03%     
==========================================
  Files        1496     1496              
  Lines      200333   200333              
  Branches     2841     2841              
==========================================
- Hits       159944   159903      -41     
- Misses      39864    39905      +41     
  Partials      525      525              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Aug 26, 2024

CodSpeed Performance Report

Merging #18370 will improve performances by 28.06%

Comparing rustc-update (5fb0890) with main (aa283e6)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main rustc-update Change
test_groupby_h2oai_q4 2.6 ms 2 ms +28.06%

@stinodego stinodego marked this pull request as ready for review August 26, 2024 08:45
@ritchie46 ritchie46 merged commit 8cfedc8 into main Aug 26, 2024
22 checks passed
@ritchie46 ritchie46 deleted the rustc-update branch August 26, 2024 09:42
@c-peters c-peters added the accepted Ready for implementation label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants