-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rust): Add FromIterator
impls for PlSmallStr
#18509
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18509 +/- ##
==========================================
- Coverage 79.85% 79.84% -0.01%
==========================================
Files 1501 1501
Lines 201829 201865 +36
Branches 2868 2868
==========================================
+ Hits 161174 161189 +15
- Misses 40109 40130 +21
Partials 546 546 ☔ View full report in Codecov by Sentry. |
I am wondering if we should. As a |
I don't have any preference - though I suppose it would let us swap it out for more performant impls in the future? @orlp might have some ideas - this was originally requested by him |
I mean it should be easy enough to swap the impl once we use |
609e134
to
3b12ee6
Compare
Ah, yes - we indeed now have native |
@@ -125,7 +125,72 @@ impl From<&String> for PlSmallStr { | |||
} | |||
} | |||
|
|||
/// FromIterator impls (TODO) | |||
impl From<Inner> for PlSmallStr { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive-by - add From<Inner>
From
PlSmallStr
,&PlSmallStr
, and all the iterator types thatString::from_iter
supports