Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Fix and extend AnyValue comparison #18534

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Sep 3, 2024

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 3.65854% with 158 lines in your changes missing coverage. Please review.

Project coverage is 79.80%. Comparing base (04d0978) to head (17225d5).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/datatypes/any_value.rs 4.51% 127 Missing ⚠️
crates/polars-utils/src/itertools/mod.rs 0.00% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18534      +/-   ##
==========================================
- Coverage   79.87%   79.80%   -0.07%     
==========================================
  Files        1501     1501              
  Lines      201823   201952     +129     
  Branches     2868     2868              
==========================================
- Hits       161200   161164      -36     
- Misses      40077    40242     +165     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 3, 2024

CodSpeed Performance Report

Merging #18534 will not alter performance

Comparing orlp:anyvalue-cmp (17225d5) with main (04d0978)

Summary

✅ 37 untouched benchmarks

@ritchie46 ritchie46 merged commit b89e772 into pola-rs:main Sep 4, 2024
21 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants