Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Empty any_horizontal should be false, not true #18545

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Sep 4, 2024

No description provided.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 4, 2024
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, good fix! Care to add a test case?

@orlp
Copy link
Collaborator Author

orlp commented Sep 4, 2024

Oof, good fix! Care to add a test case?

Done. I just came across the bug in Rust code and wanted to fix it to be sure even though I thought we couldn't reach this at first since pl.any_horizontal doesn't allow empty input. But it turns out we can actually reach it with empty selectors :)

@ritchie46 ritchie46 merged commit b1f15c3 into pola-rs:main Sep 4, 2024
25 checks passed
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (04d0978) to head (539c97d).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18545      +/-   ##
==========================================
- Coverage   79.87%   79.81%   -0.06%     
==========================================
  Files        1501     1503       +2     
  Lines      201823   201956     +133     
  Branches     2868     2868              
==========================================
- Hits       161200   161191       -9     
- Misses      40077    40219     +142     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants