fix(rust): Fix UnitVec inline clone and with_capacity
#18586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
force-pushed
the
idx-vec-clone
branch
2 times, most recently
from
13ea45b
to
9bb7f0d
Compare
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
nameexhaustion
force-pushed
the
idx-vec-clone
branch
from
9bb7f0d
to
1ae5d74
Compare
CodSpeed Performance ReportMerging #18586 will not alter performanceComparing Summary
|
|
test |
orlp
requested changes
Sep 6, 2024
nameexhaustion
changed the title
UnitVec inline cloneUnitVec inline clone and with_capacity
orlp
requested changes
Sep 6, 2024
crates/polars-utils/src/idx_vec.rs
Outdated
| fn realloc(&mut self, new_cap: usize) { | ||
| assert!(new_cap >= self.len); | ||
| assert!(new_cap >= self.len.max(1)); |
There was a problem hiding this comment.
No, it needs to be bigger than 1, not bigger or equal, I'd just write new_cap => self.len && new_cap > 1 instead of being fancy with max :). Capacity == 1 is a cursed special value. Doc comment also needs update.
orlp
approved these changes
Sep 6, 2024
|
Oh I noticed it should've been |
nameexhaustion
changed the title
UnitVec inline clone and with_capacityUnitVec inline clone and with_capacity
nameexhaustion
added
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.