Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Scalar checks #18627

Merged
merged 11 commits into from
Sep 11, 2024
Merged

fix: Scalar checks #18627

merged 11 commits into from
Sep 11, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@ritchie46 ritchie46 changed the title WIP: scalar checks fix: Scalar checks Sep 10, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 77.53846% with 73 lines in your changes missing coverage. Please review.

Project coverage is 79.90%. Comparing base (fe04390) to head (ead068c).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/aexpr/traverse.rs 80.79% 34 Missing ⚠️
crates/polars-mem-engine/src/executors/stack.rs 90.00% 4 Missing ⚠️
crates/polars-expr/src/expressions/aggregation.rs 50.00% 3 Missing ⚠️
crates/polars-expr/src/expressions/binary.rs 40.00% 3 Missing ⚠️
crates/polars-expr/src/expressions/column.rs 0.00% 3 Missing ⚠️
crates/polars-expr/src/expressions/count.rs 0.00% 3 Missing ⚠️
crates/polars-expr/src/expressions/gather.rs 0.00% 3 Missing ⚠️
crates/polars-expr/src/expressions/rolling.rs 0.00% 3 Missing ⚠️
crates/polars-expr/src/expressions/slice.rs 0.00% 3 Missing ⚠️
crates/polars-expr/src/expressions/sort.rs 0.00% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18627      +/-   ##
==========================================
- Coverage   79.91%   79.90%   -0.01%     
==========================================
  Files        1511     1514       +3     
  Lines      203201   203315     +114     
  Branches     2891     2892       +1     
==========================================
+ Hits       162388   162460      +72     
- Misses      40263    40305      +42     
  Partials      550      550              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 12cce97 into main Sep 11, 2024
27 checks passed
@ritchie46 ritchie46 deleted the scalar branch September 11, 2024 06:47
@c-peters c-peters added the accepted Ready for implementation label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants