Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly slice validity mask on pl.Object series #18631

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Sep 9, 2024

No description provided.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 9, 2024
Copy link

codspeed-hq bot commented Sep 9, 2024

CodSpeed Performance Report

Merging #18631 will improve performances by 28.27%

Comparing orlp:object-validity-slice (ea72809) with main (4d176e0)

Summary

⚡ 1 improvements
✅ 38 untouched benchmarks

Benchmarks breakdown

Benchmark main orlp:object-validity-slice Change
test_pdsh_q4 5.6 ms 4.4 ms +28.27%

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.93%. Comparing base (253057a) to head (ea72809).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18631      +/-   ##
==========================================
+ Coverage   79.91%   79.93%   +0.01%     
==========================================
  Files        1506     1506              
  Lines      203047   203057      +10     
  Branches     2889     2891       +2     
==========================================
+ Hits       162271   162313      +42     
+ Misses      40226    40194      -32     
  Partials      550      550              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp merged commit 72d861e into pola-rs:main Sep 9, 2024
26 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants