Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Check predicates in join_where #18648

Merged
merged 2 commits into from
Sep 10, 2024
Merged

chore: Check predicates in join_where #18648

merged 2 commits into from
Sep 10, 2024

Conversation

ritchie46
Copy link
Member

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Sep 10, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.88%. Comparing base (1ee6a82) to head (0fb12cb).
Report is 43 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #18648      +/-   ##
==========================================
- Coverage   79.91%   79.88%   -0.03%     
==========================================
  Files        1506     1506              
  Lines      203204   203205       +1     
  Branches     2891     2891              
==========================================
- Hits       162391   162336      -55     
- Misses      40263    40319      +56     
  Partials      550      550

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 5658e65 into main Sep 10, 2024
26 checks passed
@ritchie46 ritchie46 deleted the iejoin branch September 10, 2024 11:25
@c-peters c-peters added the accepted Ready for implementation label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees

@ritchie46 ritchie46

Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritchie46 @c-peters