refactor(rust): Allow polars to pass cargo check on windows #18672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is similar to what was done in #18498. We also added windows to
lint-rust.yml
in CI to prevent similar issues from occuring again.It fixes
cargo check
regression in windows as of 5c4e7e9 with the messageThis is caused by #18532 at
polars/crates/polars-utils/src/mmap.rs
Line 127 in ac2456c
polars/crates/polars-utils/src/mmap.rs
Lines 311 to 319 in ac2456c