Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reading nullable sliced / masked Categoricals from Parquet #20024

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

coastalwhite
Copy link
Collaborator

Fixes #20017.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 27, 2024
@ritchie46 ritchie46 merged commit a997422 into pola-rs:main Nov 27, 2024
25 checks passed
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.50%. Comparing base (85d078c) to head (be349c8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rs-parquet/src/arrow/read/deserialize/utils/mod.rs 71.42% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20024      +/-   ##
==========================================
+ Coverage   79.48%   79.50%   +0.01%     
==========================================
  Files        1556     1556              
  Lines      216493   216504      +11     
  Branches     2456     2456              
==========================================
+ Hits       172084   172127      +43     
+ Misses      43851    43819      -32     
  Partials      558      558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite deleted the fix/pq-categorical-slicing branch November 27, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parquet reader panicked on null containing dictionary types
2 participants