Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix incorrect lazy select(len()) with some select orderings #20222

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix: Fix incorrect lazy select(len()) with some select orderings #20222

merged 1 commit into from
Dec 9, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #20220

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 9, 2024
@nameexhaustion nameexhaustion mentioned this pull request Dec 9, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.62%. Comparing base (58a38af) to head (07a1f47).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20222      +/-   ##
==========================================
- Coverage   79.62%   79.62%   -0.01%     
==========================================
  Files        1565     1565              
  Lines      218188   218192       +4     
  Branches     2475     2475              
==========================================
+ Hits       173735   173736       +1     
- Misses      43886    43889       +3     
  Partials      567      567

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review December 9, 2024 08:37
@ritchie46 ritchie46 merged commit 01fadd9 into pola-rs:main Dec 9, 2024
26 checks passed
@Tachy0o-n Tachy0o-n mentioned this pull request Dec 18, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect select(len()) with some select orderings
2 participants
@nameexhaustion @ritchie46