fix: Ensure pl.datetime returns empty column when input columns are empty #20278
Conversation
haocheng6
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20278 +/- ##
==========================================
+ Coverage 79.59% 79.61% +0.02%
==========================================
Files 1565 1565
Lines 218462 218344 -118
Branches 2475 2478 +3
==========================================
- Hits 173885 173841 -44
+ Misses 44010 43936 -74
Partials 567 567 ☔ View full report in Codecov by Sentry. |
| }, | ||
| _ => { | ||
| polars_ensure!( | ||
| time_zone.is_none(), |
There was a problem hiding this comment.
This should be an assert. We panic on missing features.
There was a problem hiding this comment.
Thanks for the info! Updated in 8b48562. The existing polars_ensure on line 200 has also been replaced with assert.
| @@ -78,6 +81,29 @@ pub(super) fn datetime( | |||
| use polars_core::export::chrono::NaiveDate; | |||
| use polars_core::utils::CustomIterTools; | |||
|
|
|||
| if s.iter().any(|s| s.is_empty()) { | |||
| return Ok(Column::new_empty( | |||
| PlSmallStr::from_static("datetime"), | |||
There was a problem hiding this comment.
Can we hoist this into a variable at the start of the function? Then we can reuse that here and on line 207.
There was a problem hiding this comment.
Sure. Updated in 8b48562.
|
Thank you @haocheng6 |
Fixes #19696
In the new code, the returned column is named as "datetime" for consistency. The column name issue of
pl.datetimeis tracked by #18808.