feat: Improve error message on SchemaError #20326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partially fixes: |
kszlim
changed the title
github-actions
bot
added
fix
kszlim
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20326 +/- ##
=======================================
Coverage 79.60% 79.61%
=======================================
Files 1567 1567
Lines 218528 218528
Branches 2462 2462
=======================================
+ Hits 173969 173975 +6
+ Misses 43992 43986 -6
Partials 567 567 ☔ View full report in Codecov by Sentry. |
|
I believe the title label is correct now? |
ritchie46
changed the title
github-actions
bot
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know you want to do better typechecking and error messages at the IR level, but meanwhile this is a monotonic and small change to improve the current state of things.