Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Correcting misspelled return value and unifying regional spelling #20375

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

noexecstack
Copy link
Contributor

A misspelled return value was corrected and the mixture of US and UK spelling (normalize vs. normalise) was unified.

@noexecstack noexecstack changed the title style(python): Correcting misspelled return value and unifying regional spelling style: Correcting misspelled return value and unifying regional spelling Dec 19, 2024
@noexecstack noexecstack changed the title style: Correcting misspelled return value and unifying regional spelling style(python): correcting misspelled return value and unifying regional spelling Dec 19, 2024
@noexecstack noexecstack changed the title style(python): correcting misspelled return value and unifying regional spelling style(python): Correcting misspelled return value and unifying regional spelling Dec 19, 2024
@noexecstack noexecstack changed the title style(python): Correcting misspelled return value and unifying regional spelling refactor(python): Correcting misspelled return value and unifying regional spelling Dec 19, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars and removed title needs formatting labels Dec 19, 2024
@noexecstack
Copy link
Contributor Author

Apologies if I misread your documentation but according to the Angular convention, I thought I could use:
style(python): <Title>
I checked what the labeler regex does and it doesn't seem to cover all Angular convention types. I hope refactor covers my PR.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (db1684d) to head (ffd5d8c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20375      +/-   ##
==========================================
- Coverage   79.10%   79.10%   -0.01%     
==========================================
  Files        1572     1572              
  Lines      219958   219958              
  Branches     2465     2465              
==========================================
- Hits       173991   173989       -2     
- Misses      45399    45401       +2     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit ff00869 into pola-rs:main Dec 20, 2024
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants