feat: Add cat.contains and cat.contains_any
#20582
Open
+486
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcrumiller
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20582 +/- ##
==========================================
+ Coverage 79.86% 79.90% +0.03%
==========================================
Files 1593 1596 +3
Lines 228268 228623 +355
Branches 2600 2608 +8
==========================================
+ Hits 182311 182678 +367
+ Misses 45360 45349 -11
+ Partials 597 596 -1 ☔ View full report in Codecov by Sentry. |
|
Any movement on this one? |
mcrumiller
force-pushed
the
cat-contains
branch
from
7744eed to
63b98d5
Compare
mcrumiller
force-pushed
the
cat-contains
branch
from
1ffb831 to
a026db3
Compare
coastalwhite
approved these changes
Feb 16, 2025
Comment on lines
316
to
318
| Use the Aho-Corasick algorithm to find matches. | ||
|
|
||
| Determines if any of the patterns are contained in the string representation. |
There was a problem hiding this comment.
nit. I think these two lines should be swapped
There was a problem hiding this comment.
I copied this (with modifications) from the str.contains_any description, but yes I agree. I've swapped, and also swapped for the str.contains_any docstring as well since it's very minor. Updated in cface6b.
py-polars/polars/expr/categorical.py
Outdated
Comment on lines
325
to
327
| Use the Aho-Corasick algorithm to find matches. | ||
|
|
||
| Determines if any of the patterns are contained in the string representation. |
Comment on lines
+188
to
+204
| #[cfg(all(feature = "strings", feature = "regex"))] | ||
| pub(super) fn contains(s: &Column, pat: &str, literal: bool, strict: bool) -> PolarsResult<Column> { | ||
| let ca = s.categorical()?; | ||
| if literal { | ||
| try_apply_to_cats(ca, |s| s.contains_literal(pat)) | ||
| } else { | ||
| try_apply_to_cats(ca, |s| s.contains(pat, strict)) | ||
| } | ||
| } | ||
|
|
||
| #[cfg(all(feature = "strings", feature = "find_many"))] | ||
| fn contains_many(s: &[Column], ascii_case_insensitive: bool) -> PolarsResult<Column> { | ||
| let ca = s[0].categorical()?; | ||
| let patterns = s[1].str()?; | ||
| try_apply_to_cats(ca, |s| { | ||
| strings::contains_any(s, patterns, ascii_case_insensitive) | ||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #20257. Again, expression input patterns not allowed in
cat.contains, only string inputs. Forcontains_any, expression inputs are allowed, because these are interpreted as a list of possible patterns.