Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix error filtering after with_columns() on unit height LazyFrame #20584

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jan 7, 2025

Fixes #20489

Replaces all uses of projects_as_scalar() with is_scalar() to be consistent with the strictness check used by with_columns()

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (f104170) to head (a75a9d6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20584      +/-   ##
==========================================
- Coverage   78.98%   78.98%   -0.01%     
==========================================
  Files        1564     1564              
  Lines      220765   220759       -6     
  Branches     2504     2504              
==========================================
- Hits       174368   174361       -7     
- Misses      45823    45824       +1     
  Partials      574      574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 5dca7be into pola-rs:main Jan 7, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering with single-element series fails on lazy frame
2 participants