Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Update DataFrame join examples #20587

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

SamuelAllain
Copy link
Contributor

coalesce=True has no effect when how="left" so it should be demonstrated with how="full" instead. I kept an example of how="left" (without coalesce=True) because it might be usefull too. I don't know Rust but the doc may be adapted there too

coalesce=True has no effect when how="left" so it should be demonstrated with how="full" instead
@alexander-beedie alexander-beedie changed the title docs(python) : update join examples in frame.py docs(python): Update DataFrame join examples Jan 7, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars and removed title needs formatting labels Jan 7, 2025
Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, thx ;)

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (04004b8) to head (0400b58).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20587      +/-   ##
==========================================
- Coverage   78.97%   78.96%   -0.01%     
==========================================
  Files        1564     1564              
  Lines      220807   220807              
  Branches     2510     2510              
==========================================
- Hits       174377   174370       -7     
- Misses      45855    45862       +7     
  Partials      575      575              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 4eb8e48 into pola-rs:main Jan 7, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants