Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Update Makefile to install Python deps without --no-build #20589

Closed
wants to merge 2 commits into from

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented Jan 7, 2025

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Jan 7, 2025
@stinodego stinodego marked this pull request as ready for review January 7, 2025 10:59
@stinodego stinodego marked this pull request as draft January 7, 2025 11:09
@stinodego stinodego changed the title chore(python): Pin pytest-codspeed to 3.0.0 for now chore(python): Update Makefile to install Python deps without --no-build Jan 7, 2025
@ritchie46
Copy link
Member

But do we want to compile from source? I'd argue we don't.

@stinodego
Copy link
Contributor Author

But do we want to compile from source? I'd argue we don't.

We'd rather not, but the question is more: do we want to build from source if there is no available wheel? I'd argue yes (Orson ran into this not too long ago).

We used to have --prefer-binary for this, but uv doesn't support this. Related discussion:
astral-sh/uv#1794

In any case, I'll close this for now.

@stinodego stinodego closed this Jan 18, 2025
@stinodego stinodego deleted the pytest-codspeed branch January 20, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants