Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rust): Move morsel distribution to the computational async engine #20600

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 7, 2025

There was no reason we moved back to the I/O executor just for this.

@github-actions github-actions bot added performance Performance issues or improvements rust Related to Rust Polars labels Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (72cd66a) to head (31f0599).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
...polars-stream/src/nodes/io_sources/parquet/init.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20600      +/-   ##
==========================================
- Coverage   78.95%   78.95%   -0.01%     
==========================================
  Files        1564     1564              
  Lines      220882   220882              
  Branches     2510     2510              
==========================================
- Hits       174407   174401       -6     
- Misses      45900    45906       +6     
  Partials      575      575              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp merged commit 52ea381 into pola-rs:main Jan 7, 2025
23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants