Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not print sensitive information to output on POLARS_VERBOSE #20797

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

nameexhaustion
Copy link
Collaborator

We often request logs with POLARS_VERBOSE turned on - to prevent accidental key exposure we should not log any sensitive information. This PR instead introduces POLARS_VERBOSE_SENSITIVE for allowing logging of sensitive information.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (3696e53) to head (d6ff26e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/config.rs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20797      +/-   ##
==========================================
- Coverage   79.78%   79.78%   -0.01%     
==========================================
  Files        1561     1561              
  Lines      222015   222027      +12     
  Branches     2533     2533              
==========================================
+ Hits       177135   177139       +4     
- Misses      44296    44304       +8     
  Partials      584      584              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review January 20, 2025 09:02
@ritchie46 ritchie46 merged commit 565743f into pola-rs:main Jan 20, 2025
22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants