Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Allow column expressions in DataFrame unnest #20846

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Jan 22, 2025

Closes #20128.

We can redirect to LazyFrame to handle this consistently, dropping the passthrough method on PyDataFrame.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (24fccc4) to head (fb79ea2).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20846      +/-   ##
==========================================
- Coverage   79.64%   79.64%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      223156   223149       -7     
  Branches     2546     2546              
==========================================
- Hits       177731   177721      -10     
- Misses      44841    44844       +3     
  Partials      584      584              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Yeap, can we add a simple test to verify we the experssions work.

@alexander-beedie
Copy link
Collaborator Author

Yeap, can we add a simple test to verify we the experssions work.

Ooof... shame on me; done ✌️

@alexander-beedie alexander-beedie force-pushed the eager-unnest-consistency branch from a21490d to fb79ea2 Compare January 22, 2025 21:21
@ritchie46 ritchie46 merged commit aa1b45f into pola-rs:main Jan 23, 2025
26 of 28 checks passed
@alexander-beedie alexander-beedie deleted the eager-unnest-consistency branch January 23, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unnest() accepts pl.col() input for LazyFrame but not DataFrame
2 participants