Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure Function name correctness in cse #20929

Merged
merged 3 commits into from
Jan 27, 2025
Merged

fix: Ensure Function name correctness in cse #20929

merged 3 commits into from
Jan 27, 2025

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Jan 27, 2025

fixes #20927

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 27, 2025
Copy link
Contributor

The uncompressed lib size after this PR is 38.3617 MB.

Copy link
Contributor

The uncompressed lib size after this PR is 38.3617 MB.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.30%. Comparing base (56fb8c4) to head (2ee577b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...es/polars-plan/src/plans/optimizer/cse/cse_expr.rs 75.86% 7 Missing ⚠️
crates/polars-plan/src/utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20929      +/-   ##
==========================================
- Coverage   79.76%   79.30%   -0.46%     
==========================================
  Files        1569     1578       +9     
  Lines      222730   224135    +1405     
  Branches     2574     2574              
==========================================
+ Hits       177651   177749      +98     
- Misses      44488    45795    +1307     
  Partials      591      591              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 6a3fc59 into main Jan 27, 2025
27 checks passed
@ritchie46 ritchie46 deleted the cse branch January 27, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect results with pl.struct().value_counts().struct.unnest()
1 participant