fix: Allow for respawning of new streaming sinks #20934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
coastalwhite
commented
Jan 27, 2025
| @@ -298,7 +298,7 @@ def test_join_on_cast() -> None: | |||
| check_dtypes=False, | |||
| ) | |||
| assert df_a.lazy().join( | |||
| df_b.lazy(), on=pl.col("a").cast(pl.Int64) | |||
There was a problem hiding this comment.
drive-by: This test was flaky with the new streaming engine
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20934 +/- ##
==========================================
- Coverage 79.30% 79.28% -0.02%
==========================================
Files 1578 1578
Lines 224109 224194 +85
Branches 2574 2574
==========================================
+ Hits 177728 177755 +27
- Misses 45790 45848 +58
Partials 591 591 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.