Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Added test to check for the computation of list.len for null #20938

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

skritsotalakis
Copy link
Contributor

@skritsotalakis skritsotalakis commented Jan 27, 2025

closes #18522

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.30%. Comparing base (2eb0109) to head (6afa4ca).
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20938      +/-   ##
==========================================
- Coverage   79.77%   79.30%   -0.47%     
==========================================
  Files        1569     1578       +9     
  Lines      222898   224135    +1237     
  Branches     2574     2574              
==========================================
- Hits       177807   177746      -61     
- Misses      44500    45798    +1298     
  Partials      591      591              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcrumiller
Copy link
Contributor

FYI not sure if you meant to close two separate issues, but you linked to the same issue twice in your description.

@skritsotalakis
Copy link
Contributor Author

FYI not sure if you meant to close two separate issues, but you linked to the same issue twice in your description.

thanks! I changed it

@ritchie46 ritchie46 merged commit aa8fdf7 into pola-rs:main Feb 1, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

computation of list.len for null list seems incorrect
3 participants