Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add negative slice support to new-streaming engine #21001

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 30, 2025

This should be the last computational todo! in the new-streaming engine.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 101 lines in your changes missing coverage. Please review.

Project coverage is 79.21%. Comparing base (96a2d01) to head (b4cd857).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/negative_slice.rs 0.00% 93 Missing ⚠️
crates/polars-stream/src/physical_plan/lower_ir.rs 0.00% 7 Missing ⚠️
crates/polars-stream/src/physical_plan/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21001      +/-   ##
==========================================
- Coverage   79.34%   79.21%   -0.13%     
==========================================
  Files        1579     1583       +4     
  Lines      224319   225082     +763     
  Branches     2573     2581       +8     
==========================================
+ Hits       177976   178296     +320     
- Misses      45755    46196     +441     
- Partials      588      590       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit c3d317e into pola-rs:main Jan 30, 2025
24 checks passed
@c-peters c-peters added the accepted Ready for implementation label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants