Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Quadratic allocations when loading nested Parquet column metadata #21050

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

coastalwhite
Copy link
Collaborator

Fixes #21031.

@coastalwhite coastalwhite marked this pull request as ready for review February 3, 2025 09:52
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.20%. Comparing base (2df0404) to head (e8a0d8e).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...-parquet/src/parquet/metadata/column_descriptor.rs 42.85% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21050      +/-   ##
==========================================
+ Coverage   79.11%   79.20%   +0.09%     
==========================================
  Files        1583     1585       +2     
  Lines      225222   225583     +361     
  Branches     2586     2588       +2     
==========================================
+ Hits       178180   178684     +504     
+ Misses      46452    46309     -143     
  Partials      590      590              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 35c71b2 into pola-rs:main Feb 3, 2025
23 checks passed
@coastalwhite coastalwhite deleted the fix/pq-quadratic-allocations branch February 3, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High memory usage reading Parquet files with many struct fields
2 participants