Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update rustc #4985

Merged
merged 1 commit into from
Sep 26, 2022
Merged

chore: update rustc #4985

merged 1 commit into from
Sep 26, 2022

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added python Related to Python Polars rust Related to Rust Polars labels Sep 26, 2022
@ritchie46 ritchie46 merged commit 2b98efe into master Sep 26, 2022
@ritchie46 ritchie46 deleted the update_rust branch September 26, 2022 11:00
@messense
Copy link
Contributor

messense commented Sep 26, 2022 •
edited
Loading

FYI, cargo workspace dependencies and metadata inheritance support was added in PyO3/maturin#1123 and PyO3/maturin#1131, I plan to release maturin v0.13.4 this week.

@messense
Copy link
Contributor

messense commented Sep 26, 2022 •
edited
Loading

I'm releasing v0.13.4-beta.1 for you to try: https://github.com/PyO3/maturin/actions/runs/3127244373

Oops it's having trouble because there are two workspaces, I need to find a solution to fix it in maturin.

📦 Including license file "/Users/messense/Projects/polars/py-polars/LICENSE"
🍹 Building a mixed python/rust project
🔗 Found pyo3 bindings with abi3 support for Python ≥ 3.7
🐍 Not using a specific python interpreter
💥 maturin failed
  Caused by: Failed to build source distribution
  Caused by: Failed to add local dependency polars-core at /Users/messense/Projects/polars/polars/polars-core/Cargo.toml to the source distribution
  Caused by: In /Users/messense/Projects/polars/polars/polars-core/Cargo.toml, dependencies ahash is marked as `workspace = true`, but it is found neither in the workspace manifest nor in the known path dependencies

@messense messense mentioned this pull request Sep 26, 2022
Closed
messense
messense reviewed Sep 26, 2022
View reviewed changes
polars/polars-core/Cargo.toml
once_cell = "1"
polars-arrow = { version = "0.24.2", path = "../polars-arrow", features = ["compute"] }
polars-utils = { version = "0.24.2", path = "../polars-utils" }
rand = { version = "0.8", optional = true, features = ["small_rng", "std"] }
rand_distr = { version = "0.4", optional = true }
rayon = "1.5"
rayon.worspace = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be rayon.workspace = true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed in a follow up PR.

@cjermain
Copy link
Contributor

This is a great change! Glad to see the arrow2 dependency information consolidate.

@ritchie46
Copy link
Member Author

Yes, really neat new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense left review comments

Assignees
No one assigned
Labels
python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ritchie46 @messense @cjermain