Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Support large page sizes on aarch64 linux builds #5694

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

ghuls
Copy link
Collaborator

@ghuls ghuls commented Dec 1, 2022

No description provided.

@github-actions github-actions bot added the enhancement New feature or an improvement of an existing feature label Dec 1, 2022
@ghuls
Copy link
Collaborator Author

ghuls commented Dec 1, 2022

This should fix: #5654

Not sure if the page size will always be 64k on MacOS with linux in Docker.

@ritchie46
Copy link
Member

Thanks @ghuls

@ritchie46 ritchie46 changed the title feat: Support large page sizes on aarch64 linux builds feat(python): Support large page sizes on aarch64 linux builds Dec 2, 2022
@ritchie46 ritchie46 merged commit 509b18a into pola-rs:master Dec 2, 2022
@github-actions github-actions bot added the python Related to Python Polars label Dec 2, 2022
@chuchiy
Copy link

chuchiy commented Dec 5, 2022

Thanks for the fast release. But I just test the 0.15.2 release. It works on the 4K page size aarch64 linux kernel but still core dump at 64k page size kernel. Maybe the env config in github actions did not take effect.

If I build polars wheel using maturin from source at 64k page size kernel machine, it works as a charm.

$ getconf PAGE_SIZE
65536
$ poetry run python3
Python 3.9.15 (main, Dec 5 2022, 09:55:16)
Type "help", "copyright", "credits" or "license" for more information.

import polars
: Unsupported system page size
: Unsupported system page size
memory allocation of 2048 bytes failed
Aborted (core dumped)

$getconf PAGE_SIZE
4096
$ poetry run python3
Python 3.9.15 (main, Nov 28 2022, 06:34:37)
[GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import polars as pl
pl.show_versions()
---Version info---
Polars: 0.15.2
Index type: UInt32
Platform: Linux-5.15.0-53-generic-aarch64-with-glibc2.35
Python: 3.9.15 (main, Nov 28 2022, 06:34:37)
[GCC 11.3.0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants