Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add test for different features with cargo-hack #107

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

fMeow
Copy link
Contributor

@fMeow fMeow commented Sep 13, 2024

Again the new version of polars (v0.43) fails the compilation of pyo3-polars when feature dtype-categorical is turned on. This can be noticed before publishing with proper CI test. This PR adds additional stages in github CI pipeline to test for selected feature gates.

.github/workflows/CI.yml Outdated Show resolved Hide resolved
@fMeow
Copy link
Contributor Author

fMeow commented Nov 2, 2024

I use cargo-hack to test for every single feature. I think that's enough. @ritchie46

There is another option to test for features powerset in cargo-hack, but I think it an overkill as it have to test for 114 combinations.

@fMeow fMeow changed the title ci: add test for different features ci: add test for different features with cargo-hack Nov 2, 2024
@ritchie46 ritchie46 merged commit 6fe73b1 into pola-rs:main Dec 8, 2024
2 checks passed
@fMeow fMeow deleted the test/features branch December 9, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants