Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation errors for features: dtype-struct and dtype-full #99

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

lukeshingles
Copy link
Contributor

@lukeshingles lukeshingles commented Aug 15, 2024

When compiling with dtype-struct feature:

   Compiling pyo3-polars v0.16.0 (/Users/luke/GitHub/pyo3-polars/pyo3-polars)
error[E0433]: failed to resolve: use of undeclared type `PyList`
   --> /Users/luke/GitHub/pyo3-polars/pyo3-polars/src/types.rs:475:30
    |
475 |                 let fields = PyList::new_bound(py, iter);
    |                              ^^^^^^ use of undeclared type `PyList`
    |
help: a struct with a similar name exists
    |
475 |                 let fields = PyDict::new_bound(py, iter);
    |                              ~~~~~~
help: consider importing this struct
    |
1   + use pyo3::types::PyList;
    |

For more information about this error, try `rustc --explain E0433`.
error: could not compile `pyo3-polars` (lib) due to 1 previous error

When compiling with the dtype-full feature:

   Compiling pyo3-polars v0.16.0 (/Users/luke/GitHub/pyo3-polars/pyo3-polars)
warning: unused import: `pyo3::types::PyList`
  --> /Users/luke/GitHub/pyo3-polars/pyo3-polars/src/types.rs:23:5
   |
23 | use pyo3::types::PyList;
   |     ^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

error[E0277]: the trait bound `PySeries: From<polars::prelude::Series>` is not satisfied

This PR fixes these compilation errors and the dtype-struct feature is now implied by dtype-full. The dtype-struct feature is needed to resolve #98 when the performant feature is enabled for polars.

@ritchie46 ritchie46 merged commit a535465 into pola-rs:main Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error when performant feature is enabled for polars
2 participants