Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename $str$parse_int() to $str$to_integer() #1037

Closed
wants to merge 4 commits into from

Conversation

etiennebacher
Copy link
Collaborator

Mentioned in #952

@eitsupi
Copy link
Collaborator

eitsupi commented Apr 15, 2024

Thank you.
However, upon closer inspection of the Python documentation, I realized that the problem is not just a name change.
Sorry for the duplication of work, but please see #1038.

@etiennebacher
Copy link
Collaborator Author

IINM, in #1038, arguments become named, the default value changes, and you updated the docs (changed title, added an example for base 16, etc.), right? If that's the case I could integrate those changes in this PR since I already updated the tests and changelog

@etiennebacher
Copy link
Collaborator Author

Nvm I see you updated #1038

@eitsupi eitsupi deleted the rename-parse-int branch April 15, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants