Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ligand RMSD metrics #199

Merged
merged 14 commits into from
Sep 21, 2024
Merged

Add ligand RMSD metrics #199

merged 14 commits into from
Sep 21, 2024

Conversation

zhu0619
Copy link
Contributor

@zhu0619 zhu0619 commented Sep 13, 2024

Changelogs

  • Added metric rmsd_coverage for docking related benchmarks
  • Added unit tests

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

The rmsd metrics are implemented based on the Posebuster codebase. A few modifications were made, replacing RDKit callables with equivalent Datamol functions. The RMSD calculation was also simplified to evaluate only the first conformer of the predicted molecule and to consider only heavy atoms.

Note: Posebusters provides a series of checkers, known as 'Posebuster Checkers,' to further filter out unwanted docked ligand conformers. To avoid over-complicating Polaris metrics module with case-specific metrics, users should apply these filters before uploading results to the Polaris hub.

@zhu0619 zhu0619 requested a review from cwognum as a code owner September 13, 2024 21:07
@zhu0619 zhu0619 added the feature Annotates any PR that adds new features; Used in the release process label Sep 13, 2024
@zhu0619 zhu0619 marked this pull request as draft September 13, 2024 21:09
@zhu0619 zhu0619 marked this pull request as ready for review September 16, 2024 21:21
Copy link
Collaborator

@cwognum cwognum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhu0619 !

I understand that you intentionally mimicked the PoseBusters implementation, but I had some questions.

polaris/evaluate/_metric.py Outdated Show resolved Hide resolved
polaris/evaluate/utils.py Outdated Show resolved Hide resolved
polaris/evaluate/metrics/docking_metrics.py Outdated Show resolved Hide resolved
polaris/evaluate/metrics/docking_metrics.py Outdated Show resolved Hide resolved
polaris/evaluate/metrics/docking_metrics.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/test_evaluate.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
polaris/evaluate/metrics/docking_metrics.py Outdated Show resolved Hide resolved
polaris/evaluate/metrics/docking_metrics.py Outdated Show resolved Hide resolved
@cwognum cwognum mentioned this pull request Sep 19, 2024
5 tasks
@zhu0619 zhu0619 requested a review from Fransu86 September 19, 2024 02:10
@zhu0619 zhu0619 requested a review from cwognum September 19, 2024 18:25
Copy link
Collaborator

@cwognum cwognum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Fransu86 and @zhu0619 ! I love how much this has simplified!

Couple more questions... As always!

polaris/evaluate/metrics/docking_metrics.py Outdated Show resolved Hide resolved
polaris/evaluate/metrics/docking_metrics.py Show resolved Hide resolved
polaris/evaluate/metrics/docking_metrics.py Outdated Show resolved Hide resolved
polaris/evaluate/metrics/docking_metrics.py Outdated Show resolved Hide resolved
tests/test_evaluate.py Show resolved Hide resolved
@zhu0619 zhu0619 requested a review from cwognum September 21, 2024 00:07
Copy link
Collaborator

@cwognum cwognum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for your patience! 🙏

polaris/evaluate/metrics/docking_metrics.py Outdated Show resolved Hide resolved
@zhu0619 zhu0619 merged commit e5370b7 into main Sep 21, 2024
4 checks passed
@cwognum cwognum mentioned this pull request Oct 16, 2024
@jstlaurent jstlaurent deleted the feat/evaluation branch December 4, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Annotates any PR that adds new features; Used in the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants