Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Exclude some computed properties during caching #213

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix: Exclude some computed properties during caching #213

merged 1 commit into from
Oct 31, 2024

Conversation

cwognum
Copy link
Collaborator

@cwognum cwognum commented Oct 31, 2024

Changelogs

  • Computing the zarr checksum manifest properties during caching would fail. We thus exclude these properties from the model_dump()

@cwognum cwognum added the fix Annotates any PR that fixes bugs label Oct 31, 2024
@cwognum cwognum self-assigned this Oct 31, 2024
@cwognum
Copy link
Collaborator Author

cwognum commented Oct 31, 2024

I'm going to skip review given that I would like to cut a new release of the client tonight before the announcement tomorrow.

@cwognum cwognum merged commit 8e94f88 into main Oct 31, 2024
4 checks passed
@cwognum cwognum deleted the fix/dataset-v2-cache branch October 31, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstlaurent jstlaurent Awaiting requested review from jstlaurent

Assignees

@cwognum cwognum

Labels
fix Annotates any PR that fixes bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cwognum