Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow extra settings in the .env file #216

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: Allow extra settings in the .env file #216

merged 1 commit into from
Nov 11, 2024

Conversation

jstlaurent
Copy link
Contributor

@jstlaurent jstlaurent commented Nov 11, 2024 •
edited
Loading

Changelogs

  • Allow extra settings in the .env file without raising an error

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • [ ] Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • [ ] Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

Issues

@jstlaurent jstlaurent added the fix Annotates any PR that fixes bugs label Nov 11, 2024
@jstlaurent jstlaurent self-assigned this Nov 11, 2024
cwognum
cwognum approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@cwognum cwognum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jstlaurent !

@jstlaurent jstlaurent merged commit 225b405 into main Nov 11, 2024
4 checks passed
@jstlaurent jstlaurent deleted the fix/extra-settings branch November 11, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwognum cwognum cwognum approved these changes

@mercuryseries mercuryseries mercuryseries approved these changes

@zhu0619 zhu0619 Awaiting requested review from zhu0619

Assignees

@jstlaurent jstlaurent

Labels
fix Annotates any PR that fixes bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PolarisHubSettings does not play well with other .env files
3 participants
@jstlaurent @mercuryseries @cwognum