Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

support polaris ratelimit ability #10

Open
chuntaojun opened this issue Jan 6, 2022 · 6 comments
Open

support polaris ratelimit ability #10

chuntaojun opened this issue Jan 6, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@chuntaojun
Copy link
Member

What is the feature you want to add?

Why do you want to add this feature?

How to implement this feature?

Additional context
Add any other context or screenshots about the feature request here.

@chuntaojun chuntaojun added the enhancement New feature or request label Jan 6, 2022
@chuntaojun
Copy link
Member Author

@quicksandznzn we can talk here

@quicksandznzn
Copy link
Contributor

@quicksandznzn we can talk here

👌
what should I do

@chuntaojun
Copy link
Member Author

  1. There should be a separate starter for current limiting. Only when this starter is introduced will the current limiting capability be enabled.
  2. I think the current limit should be done on the provider side, through the request interceptor, in which the relevant current limit judgments are made

@quicksandznzn
Copy link
Contributor

  1. There should be a separate starter for current limiting. Only when this starter is introduced will the current limiting capability be enabled.
  2. I think the current limit should be done on the provider side, through the request interceptor, in which the relevant current limit judgments are made

i got it ,i should refer to com.tencent.polaris.ratelimit.api.core.LimitAPI , right?

@chuntaojun
Copy link
Member Author

  1. There should be a separate starter for current limiting. Only when this starter is introduced will the current limiting capability be enabled.
  2. I think the current limit should be done on the provider side, through the request interceptor, in which the relevant current limit judgments are made

i got it ,i should refer to com.tencent.polaris.ratelimit.api.core.LimitAPI , right?

yes

@quicksandznzn
Copy link
Contributor

  1. There should be a separate starter for current limiting. Only when this starter is introduced will the current limiting capability be enabled.
  2. I think the current limit should be done on the provider side, through the request interceptor, in which the relevant current limit judgments are made

i got it ,i should refer to com.tencent.polaris.ratelimit.api.core.LimitAPI , right?

yes

I have some questions?

How do I get these fields for com.tencent.polaris.ratelimit.api.rpc.QuotaRequest

com.tencent.polaris.ratelimit.api.rpc.QuotaRequest should be a comment

quicksandznzn added a commit to quicksandznzn/spring-boot-polaris that referenced this issue Jan 10, 2022
quicksandznzn added a commit to quicksandznzn/spring-boot-polaris that referenced this issue Jan 10, 2022
quicksandznzn added a commit to quicksandznzn/spring-boot-polaris that referenced this issue Jan 11, 2022
quicksandznzn added a commit to quicksandznzn/spring-boot-polaris that referenced this issue Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants